Do not require component Animator on NetworkAnimator.#2812
Closed
jeffgamedev wants to merge 2 commits intoUnity-Technologies:developfrom
jeffgamedev:enhancement/remove-animator-requirement
Closed
Do not require component Animator on NetworkAnimator.#2812jeffgamedev wants to merge 2 commits intoUnity-Technologies:developfrom jeffgamedev:enhancement/remove-animator-requirement
jeffgamedev wants to merge 2 commits intoUnity-Technologies:developfrom
jeffgamedev:enhancement/remove-animator-requirement
Conversation
|
jeffgamedev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Member
|
This was migrated to the public repository in #2872 and will be included in the v1.9.0 update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the hard RequireComponent of Animator from component NetworkAnimator. The reason is that NetworkAnimator does not in fact require an Animator object to be on the game object, and functions just as well accessing a child game object's Animator.
The NetworkAnimator requires a reference to any Animator, not an Animator on the same game object. In the current implementation, this requires my Player game object to have an unused Animator attached due to the component being required.
Changelog
[RequireComponent(typeof(Animator))]on NetworkAnimator component.Suggestions for the future
Allow NetworkAnimator to throw 1 warning if the Animator reference is empty instead of constantly throwing errors.