Skip to content

Added null ref check into CodeGenHelpers.cs#2571

Closed
andreyshade wants to merge 1 commit intoUnity-Technologies:developfrom
andreyshade:fix/fix_null_check
Closed

Added null ref check into CodeGenHelpers.cs#2571
andreyshade wants to merge 1 commit intoUnity-Technologies:developfrom
andreyshade:fix/fix_null_check

Conversation

@andreyshade
Copy link
Copy Markdown

Fixed NullRefference exception in CodeGenHelpers after package update
(0,0): error - System.NullReferenceException: Object reference not set to an instance of an object.|| at Unity.Netcode.Editor.CodeGen.CodeGenHelpers.IsSubclassOf(TypeReference typeReference, TypeReference baseClass)

@andreyshade andreyshade requested a review from a team as a code owner May 25, 2023 12:30
@unity-cla-assistant
Copy link
Copy Markdown

unity-cla-assistant commented May 25, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ShadauxCat
Copy link
Copy Markdown
Collaborator

Hi @andreyshade! Thank you for your contribution!

For reasons related to our internal CI process, we're unable to directly incorporate PRs from the community. I've opened a new PR with your fix as #2581 and we're targeting including this fix in our upcoming 1.5 release.

Since I've moved the PR to that new PR, I'm going to close this one. Thank you again for your contribution.

@ShadauxCat ShadauxCat closed this Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants