Skip to content

fix: missing value on NetworkListEvent for EventType.RemoveAt events [MTT-6354]#2559

Merged
NoelStephensUnity merged 4 commits intodevelopfrom
fix/networklist-event-removeat-user-submitted-2543
May 12, 2023
Merged

fix: missing value on NetworkListEvent for EventType.RemoveAt events [MTT-6354]#2559
NoelStephensUnity merged 4 commits intodevelopfrom
fix/networklist-event-removeat-user-submitted-2543

Conversation

@NoelStephensUnity
Copy link
Copy Markdown
Member

@NoelStephensUnity NoelStephensUnity commented May 12, 2023

Resolve #2542

This PR adds the value on NetworkListEvent for EventType.RemoveAt events server side.
The code for server is now the same as in ReadDelta function used by the client.

MTT-6354

Changelog

  • Fixed: missing value on NetworkListEvent for EventType.RemoveAt events server side.

Testing and Documentation

  • Includes integration test NetworkVariableTest updates.
  • No documentation changes or additions were necessary.

NoelStephensUnity and others added 3 commits May 12, 2023 10:53
Updated the NetworkList remove tests to be combined into one test and to validate that the list changed event is returning the value of the element removed.

Cleaned up the tests a bit and removed some legacy tests that were being ignored and no longer serve a purpose.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review May 12, 2023 16:44
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner May 12, 2023 16:44
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) May 12, 2023 16:52
@NoelStephensUnity NoelStephensUnity changed the title fix: missing value on NetworkListEvent for EventType.RemoveAt events … fix: missing value on NetworkListEvent for EventType.RemoveAt events [MTT-6354] May 12, 2023
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) May 12, 2023 17:00
@NoelStephensUnity NoelStephensUnity merged commit 688640c into develop May 12, 2023
@NoelStephensUnity NoelStephensUnity deleted the fix/networklist-event-removeat-user-submitted-2543 branch May 12, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NetworkListEvent miss value for EventType.RemoveAt events server side

3 participants