fix: fixing an exception and error logging when two different objects are shown and hidden on the same frame [MTT-6303]#2535
Merged
jeffreyrainy merged 4 commits intodevelopfrom May 2, 2023
Conversation
… are shown and hidden on the same frame (#2524)
Member
NoelStephensUnity
left a comment
There was a problem hiding this comment.
Just need a changelog entry and I will appove!
👍
…y-Technologies/com.unity.netcode.gameobjects into fix/g-2524-concurrent-show-and-hide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a check on
networkObject.Observers.Remove(clientId);that the observer can actually be removed as, otherwise, a thrown exception would break the show/hide functionality.MTT-6303
Pertains to issue #2524.