Skip to content

fix: g-2501 Connection disapproval results in spam logging 10 seconds later #2515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeffreyrainy wants to merge 1 commit into from
Closed

fix: g-2501 Connection disapproval results in spam logging 10 seconds later #2515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions com.unity.netcode.gameobjects/Runtime/Connection/NetworkConnectionManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,13 +448,7 @@ private IEnumerator ApprovalTimeout(ulong clientId)
{
if (timedOut)
{
if (LocalClient.IsServer)
{
// Log a warning that the transport detected a connection but then did not receive a follow up connection request message.
// (hacking or something happened to the server's network connection)
NetworkLog.LogWarning($"Server detected a transport connection from Client-{clientId}, but timed out waiting for the connection request message.");
}
else
if (!LocalClient.IsServer)
{
// We only provide informational logging for the client side
NetworkLog.LogInfo("Timed out waiting for the server to approve the connection request.");
Expand Down Expand Up @@ -646,6 +640,8 @@ internal void HandleConnectionApproval(ulong ownerClientId, NetworkManager.Conne
}
else
{
NetworkLog.LogInfo($"Disconnecting disapproved client {ownerClientId}");

if (!string.IsNullOrEmpty(response.Reason))
{
var disconnectReason = new DisconnectReasonMessage
Expand Down