Skip to content

fix: g-2501 Connection disapproval results in spam logging 10 seconds later#2514

Merged
jeffreyrainy merged 4 commits intodevelopfrom
fix/2501-connection-approval-refused-complex
Apr 19, 2023
Merged

fix: g-2501 Connection disapproval results in spam logging 10 seconds later#2514
jeffreyrainy merged 4 commits intodevelopfrom
fix/2501-connection-approval-refused-complex

Conversation

@jeffreyrainy
Copy link
Copy Markdown
Contributor

@jeffreyrainy jeffreyrainy commented Apr 17, 2023 •
edited by NoelStephensUnity
Loading

#2501

Pertains to MTT-6208

jeffreyrainy and others added 4 commits April 17, 2023 09:05
@jeffreyrainy
fix: g-2501 Connection disapproval results in spam logging 10 seconds…
d4cd587 
… later
@NoelStephensUnity
fix
f6faf4d 
Minor adjustments to get this PR passing the connection approval timeout tests.
@NoelStephensUnity
Merge branch 'develop' into fix/2501-connection-approval-refused-complex
7bf5e86
@NoelStephensUnity
update
28dcebc 
Reverting accidental change in ProcessPendingApprovals that shouldn't have been changed.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review April 19, 2023 10:50
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner April 19, 2023 10:50
NoelStephensUnity
NoelStephensUnity approved these changes Apr 19, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThusSpokeNomad
Between #2515 and this approach, this one looks like the best solution to resolving #2501.
The other approach removes the notification that a client timed out during approval (which was actually a fix for an earlier issue).
Thoughts?

0xFA11
0xFA11 approved these changes Apr 19, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@0xFA11 0xFA11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, LGTM 🚀

@jeffreyrainy jeffreyrainy merged commit 689268a into develop Apr 19, 2023
@jeffreyrainy jeffreyrainy deleted the fix/2501-connection-approval-refused-complex branch April 19, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NoelStephensUnity NoelStephensUnity NoelStephensUnity approved these changes

+1 more reviewer

@0xFA11 0xFA11 0xFA11 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeffreyrainy @0xFA11 @NoelStephensUnity