Skip to content

chore: release 1.3.1 merge to develop#2490

Merged
ShadauxCat merged 13 commits intodevelopfrom
chore/release_1.3.1_merge_to_develop
Apr 6, 2023
Merged

chore: release 1.3.1 merge to develop#2490
ShadauxCat merged 13 commits intodevelopfrom
chore/release_1.3.1_merge_to_develop

Conversation

@ShadauxCat
Copy link
Copy Markdown
Collaborator

No description provided.

ShadauxCat and others added 12 commits February 13, 2023 11:32
…r. [MTT-5458] (#2410)

fix: Network Prefabs List wasn't persisting changes made in the editor.
* fix

This fixes the issue with nightly crashes in the ParentDynamicUnderInScenePlaced test.

* update

adding comment about the fix for console crashes.
* fix: Detection and graceful handling of corrupt packets

Adds multiple ways to detect and handle corrupt packets that could otherwise cause issues and put the game into a bad state, or potentially cause crashes:

- A "magic" value at the start of each packet helps when looking at packet dumps to see where potential start-of-packet is if the data gets offset (as was seen in the recent BatchSendQueue corruption bug)
- A "size in bytes" value helps us detect if the packet has been truncated or if garbage has been added to the end
- A "hash" value helps to detect when the other values are correct but one or more bytes within the packet have been corrupted

Additionally, code has been added to refuse to process ConnectionRequestMessage or ConnectionAcceptedMessage on an alredy-established connection, or either of those being received by the wrong side, as those could otherwise be used as a vector for attack by a malicious actor and render the framework completely broken.

In all cases, if these issues occur, the log requests the user to file an issue with us with the full hex dump of the packet that was received.
Fixes an issue with duplicate prefab entries in the default prefab list when reimporting.

MTT-5541
chore: Bump version to 1.3.1
# Conflicts:
#	com.unity.netcode.gameobjects/CHANGELOG.md
#	com.unity.netcode.gameobjects/Tests/Editor/NetworkManagerConfigurationTests.cs
#	com.unity.netcode.gameobjects/Tests/Runtime/InvalidConnectionEventsTest.cs
#	com.unity.netcode.gameobjects/package.json
@ShadauxCat ShadauxCat requested review from a team and 0xFA11 as code owners April 6, 2023 15:33
@ShadauxCat ShadauxCat enabled auto-merge (squash) April 6, 2023 15:34
@ShadauxCat ShadauxCat merged commit b9f9ceb into develop Apr 6, 2023
@ShadauxCat ShadauxCat deleted the chore/release_1.3.1_merge_to_develop branch April 6, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants