Skip to content

refactor: half types and mathematics assembly references#2456

Closed
NoelStephensUnity wants to merge 17 commits intodevelopfrom
refactor/half-types-and-mathematics-references
Closed

refactor: half types and mathematics assembly references#2456
NoelStephensUnity wants to merge 17 commits intodevelopfrom
refactor/half-types-and-mathematics-references

Conversation

@NoelStephensUnity
Copy link
Copy Markdown
Member

@NoelStephensUnity NoelStephensUnity commented Mar 15, 2023 •
edited
Loading

This PR refactors the more recent NetworkTransform updates (#2388) by replacing some of the half precision implementations with that of the Unity.Mathematics types. It also adds all of the Unity.Mathematics types to the NGO serialization pipeline.

Testing and Documentation

  • Includes integration test and updates to existing tests.
  • No documentation changes or additions were necessary.

@NoelStephensUnity
update
71867e6 
adding asmdef references to Unity.Mathematics
@NoelStephensUnity
refactor
4157d28 
updated HalfVector3 and HalfVector4 with Unity.Mathematics types.
removed classes no longer needed.
renamed HalfVector3DeltaPosition to NetworkDeltaPosition and made that use HalfVector3.
@NoelStephensUnity NoelStephensUnity mentioned this pull request Mar 15, 2023
Merged
@NoelStephensUnity
style
e81f9ea 
removing whitespace
@NoelStephensUnity
update
e6e5dfb 
setting the Vector4 to size of 4 (not 3).
Updating the teleport fix for testing purposes.
@NoelStephensUnity
test
7df3bc5 
mirroring PR-2451 changes to NetworkTransformStateTests for the teleport fix.
@NoelStephensUnity
Merge branch 'develop' into refactor/half-types-and-mathematics-refer…
440274e 
…ences
@NoelStephensUnity
update
75c898b 
Added all Mathematics types to the serialization pipeline.
@NoelStephensUnity
update
0280189 
Added arrays for all Unity.Mathematics types.
Fixed some managed read/write issues with Unity.Mathematics types.
@NoelStephensUnity
test
f926105 
Added the tests for the Unity.Mathematics types.
@NoelStephensUnity
Merge branch 'develop' into refactor/half-types-and-mathematics-refer…
4ccd7dd 
…ences
0xFA11
0xFA11 reviewed Mar 22, 2023
View reviewed changes
Comment thread com.unity.netcode.gameobjects/Runtime/Serialization/FastBufferWriter.cs Outdated
0xFA11
0xFA11 reviewed Mar 22, 2023
View reviewed changes
Comment thread com.unity.netcode.gameobjects/Runtime/Serialization/FastBufferWriter.cs Outdated
0xFA11
0xFA11 reviewed Mar 22, 2023
View reviewed changes
Comment thread com.unity.netcode.gameobjects/Runtime/Serialization/FastBufferWriter.cs Outdated
0xFA11
0xFA11 reviewed Mar 22, 2023
View reviewed changes
Comment thread com.unity.netcode.gameobjects/Runtime/Serialization/FastBufferWriter.cs Outdated
@NoelStephensUnity
update
8caa42c 
Finished getting Unity.Mathematics types added to all pertinent serialization pipelines.
Added XML API documentation to all methods within classes/structs/interfaces that had XML API documentation for other types.
@NoelStephensUnity
test
fa012de 
Very basic test to validate that all Unity.Mathematics types can be serialized within an INetworkSerializable implementation.
@NoelStephensUnity
test
178eb1e 
adding some debug information.
@NoelStephensUnity
test
8cf349a 
Fixing typos in tests for Unity.Mathematics types.
@NoelStephensUnity
Merge branch 'develop' into refactor/half-types-and-mathematics-refer…
4dd548b 
…ences
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review March 24, 2023 14:43
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner March 24, 2023 14:43
@NoelStephensUnity
style
f2ac778 
removing xml doc param that is no longer valid
@NoelStephensUnity
style
5a335ba 
whitespace correction
@NoelStephensUnity NoelStephensUnity marked this pull request as draft March 24, 2023 18:38
@NoelStephensUnity
Copy link
Copy Markdown
Member Author

NoelStephensUnity commented Mar 24, 2023

Most likely going with PR-2473
(this PR has too many public API additions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xFA11 0xFA11 Awaiting requested review from 0xFA11

@EmandM EmandM Awaiting requested review from EmandM EmandM will be requested when the pull request is marked ready for review EmandM is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NoelStephensUnity @0xFA11