fix: NetworkAnimator generating AnimationCurve warnings#2416
Merged
NoelStephensUnity merged 6 commits intodevelopfrom Mar 2, 2023
Merged
fix: NetworkAnimator generating AnimationCurve warnings#2416NoelStephensUnity merged 6 commits intodevelopfrom
NoelStephensUnity merged 6 commits intodevelopfrom
Conversation
Migrating the last PR's change log into the Unreleased section.
samlucas-unity
approved these changes
Mar 1, 2023
ShadauxCat
approved these changes
Mar 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where
NetworkAnimatorwas building a delta check list for any parameter not controlled byAnimationCurveduring initialization which could change during runtime. This update generates a delta check list for all parameters and culls out any parameter controlled by anAnimationCurvewhen checking for parameter deltas. This includes an additional minor fix to an issue that could occur where if the associatedAnimator(assigned toNetworkAnimator) was disabled in the editor it would spam exceptions to the console log.MTT-5491
Related Github Issue:
#2391
Changelog
Animatorproperties toAnimationCurves would causeNetworkAnimatorto attempt to update those changes.NetworkAnimatorwould not check if its associatedAnimatorwas valid during serialization and would spam exceptions in the editor console.indicate where the entry should go.Testing and Documentation