Skip to content

fix: resolves the issue with console crashes #2411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShadauxCat merged 2 commits into from
Feb 16, 2023
Merged

fix: resolves the issue with console crashes #2411

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70bf20a
fix
NoelStephensUnity Feb 14, 2023
a0946c3
update
NoelStephensUnity Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions testproject/Assets/Tests/Runtime/ObjectParenting/ParentDynamicUnderInScenePlaced.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,7 @@ protected override void OnServerAndClientsCreated()

protected override IEnumerator OnStartedServerAndClients()
{
m_ServerNetworkManager.SceneManager.DisableValidationWarnings(true);
m_ServerNetworkManager.SceneManager.ClientSynchronizationMode = LoadSceneMode.Additive;
m_ServerNetworkManager.SceneManager.SetClientSynchronizationMode(LoadSceneMode.Additive);
return base.OnStartedServerAndClients();
}

Expand All @@ -65,7 +64,8 @@ protected override void OnNewClientStarted(NetworkManager networkManager)
private NetworkObject m_FailedValidation;
private bool TestParentedAndNotInScenePlaced()
{
var serverPlayer = m_ServerNetworkManager.LocalClient.PlayerObject;
// Always assign m_FailedValidation to avoid possible null reference crashes.
var serverPlayer = m_FailedValidation = m_ServerNetworkManager.LocalClient.PlayerObject;
if (serverPlayer.transform.parent == null || serverPlayer.IsSceneObject.Value == true)
{
m_FailedValidation = serverPlayer;
Expand Down Expand Up @@ -111,9 +111,11 @@ public IEnumerator ParentUnderInSceneplaced()
m_ServerNetworkManager.SceneManager.LoadScene(k_SceneToLoad, LoadSceneMode.Additive);
// Wait for the scene with the in-scene placed NetworkObject to be loaded
yield return WaitForConditionOrTimeOut(() => m_SceneIsLoaded == true);
AssertOnTimeout($"Timed out waiting for the scene {k_SceneToLoad} to load!");

// Wait for the host-server's player to be parented under the in-scene placed NetworkObject
yield return WaitForConditionOrTimeOut(TestParentedAndNotInScenePlaced);
AssertOnTimeout($"[{m_FailedValidation.name}] Failed validation! InScenePlaced ({m_FailedValidation.IsSceneObject.Value}) | Was Parented ({m_FailedValidation.transform.position != null})");

// Now dynamically spawn a NetworkObject to also test dynamically spawned NetworkObjects being parented
// under in-scene placed NetworkObjects
Expand Down