Skip to content

fix: NetworkShowHideTests fail on HideThenShowAndRpc #2400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NoelStephensUnity merged 13 commits into from
Feb 6, 2023
Merged

fix: NetworkShowHideTests fail on HideThenShowAndRpc #2400

Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
52abef4
test fix
NoelStephensUnity Jan 31, 2023
02576fb
test
NoelStephensUnity Jan 31, 2023
2c98346
update
NoelStephensUnity Feb 1, 2023
7d299ae
style
NoelStephensUnity Feb 1, 2023
0ad0792
style
NoelStephensUnity Feb 1, 2023
25010f9
update
NoelStephensUnity Feb 1, 2023
79a90cf
fix
NoelStephensUnity Feb 1, 2023
c8daab6
update
NoelStephensUnity Feb 1, 2023
0092a98
Merge branch 'develop' into fix/networkshowhidetests-fail-on-hidethen…
NoelStephensUnity Feb 1, 2023
d753fb1
update
NoelStephensUnity Feb 1, 2023
e3e75b5
test
NoelStephensUnity Feb 2, 2023
28959d2
Merge branch 'develop' into fix/networkshowhidetests-fail-on-hidethen…
NoelStephensUnity Feb 2, 2023
ee56705
test fix
NoelStephensUnity Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion com.unity.netcode.gameobjects/Tests/Runtime/NetworkShowHideTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,9 @@ public IEnumerator NetworkShowHideAroundListModify()
Debug.Log("Running HideThenShowAndRPC");
ShowHideObject.ClientIdsRpcCalledOn = new List<ulong>();
yield return HideThenShowAndRPC();
Debug.Assert(ShowHideObject.ClientIdsRpcCalledOn.Count == NumberOfClients + 1);
// Provide enough time for slower systems or VM systems possibly under a heavy load could fail on this test
yield return WaitForConditionOrTimeOut(() => ShowHideObject.ClientIdsRpcCalledOn.Count == NumberOfClients + 1);
AssertOnTimeout($"Timed out waiting for ClientIdsRpcCalledOn.Count ({ShowHideObject.ClientIdsRpcCalledOn.Count}) to equal ({NumberOfClients + 1})!");
break;

}
Expand Down