fix: NetcodeSettingsProvider Exception [MTT-5217]#2345
Merged
NoelStephensUnity merged 5 commits intodevelopfrom Dec 12, 2022
Merged
fix: NetcodeSettingsProvider Exception [MTT-5217]#2345NoelStephensUnity merged 5 commits intodevelopfrom
NoelStephensUnity merged 5 commits intodevelopfrom
Conversation
| { | ||
| m_LabelContent = labelText; | ||
| AdjustLableSize(labelText, layoutOffset); | ||
| AdjustLabelSize(labelText, layoutOffset); |
jeffreyrainy
approved these changes
Dec 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since UI Element helper classes were being instantiated when they were declared, when entering into play mode, in unity 2020.3.x versions, the
EditorStyles.labelwas not yet assigned and would throw an exception (in 2021 and later versionsEditorStyles.labelis assigned at that point in time). This PR resolves the issue by instantiating the helper classes whenOnGuiHandleris invoked.MTT-5217
Changelog
NetcodeSettingsProviderwould throw an exception in Unity 2020.3.x versions.Testing and Documentation