fix: not using NativeArrayExtensions.IndexOf as this API changed in 21.0-pre.2#2303
Merged
jeffreyrainy merged 4 commits intodevelopfrom Nov 10, 2022
Merged
Conversation
NoelStephensUnity
approved these changes
Nov 9, 2022
0xFA11
approved these changes
Nov 10, 2022
0xFA11
reviewed
Nov 10, 2022
Contributor
0xFA11
left a comment
There was a problem hiding this comment.
not to be too picky but fix: or refactor: for the title?
Contributor
Author
Well, it's a build break. This fixes the build ;-). But yeah, I don't care much either way. I care much more about the fact that 7 hours later Yamato is not even started. Sigh. |
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…1.0-pre.2 (Unity-Technologies#2303) fix: not using NativeArrayExtensions.IndexOf as this API changed in 2.1.0-pre.2 Co-authored-by: ashwini <36935028+ashwinimurt@users.noreply.github.com> Co-authored-by: Fatih Mar <mfatihmar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simpler usage of
int index = m_List.IndexOf(item);instead of removedint index = NativeArrayExtensions.IndexOf(m_List, item);