fix: NetworkObjects do not honor when Auto Object Parent Sync is turned off#2281
Merged
NoelStephensUnity merged 5 commits intodevelopfrom Oct 28, 2022
Merged
Conversation
The test to validate that nested in-scene placed NetworkObjects that both have Auto Object Parent Synchronization enabled and disabled synchronize their transforms properly on the client side. The same test covers NetworkObjects nested under GameObjects with no NetworkObject components. All nested instances have varying position, rotation, and scale values.
0xFA11
reviewed
Oct 28, 2022
| /// Helper class that builds 4 transform lists based on parent-child hierarchy | ||
| /// for the <see cref="ParentingInSceneObjectsTests.InSceneNestedAutoSyncObjectTest"/> | ||
| /// </summary> | ||
| public class ParentinAutoSyncManager : NetworkBehaviour |
Contributor
There was a problem hiding this comment.
Suggested change
| public class ParentinAutoSyncManager : NetworkBehaviour | |
| public class ParentingAutoSyncManager : NetworkBehaviour |
Member
Author
There was a problem hiding this comment.
! (>.<) DOH!
Thank you for catching that spelling issue.
Added the "g" to the class and filename.
0xFA11
approved these changes
Oct 28, 2022
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…ed off (Unity-Technologies#2281) * fix This resolves the issue where NetworkObjects were not taking Auto Object Parent Sync into consideration. * test The test to validate that nested in-scene placed NetworkObjects that both have Auto Object Parent Synchronization enabled and disabled synchronize their transforms properly on the client side. The same test covers NetworkObjects nested under GameObjects with no NetworkObject components. All nested instances have varying position, rotation, and scale values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix resolves a regression based bug from the parenting updates and added scale synchronization in V1.1.0.
Auto Object Parent Synchronization was not taken into consideration with those updates.
MTT-5000
Changelog
NetworkObjectswere not honoring theAutoObjectParentSyncproperty.Testing and Documentation