fix: flushing send and receive queues upon disconnection#2274
Merged
jeffreyrainy merged 1 commit intodevelopfrom Oct 25, 2022
Merged
fix: flushing send and receive queues upon disconnection#2274jeffreyrainy merged 1 commit intodevelopfrom
jeffreyrainy merged 1 commit intodevelopfrom
Conversation
jeffreyrainy
commented
Oct 24, 2022
| private void DisconnectRemoteClient(ulong clientId) | ||
| { | ||
| var transportId = ClientIdToTransportId(clientId); | ||
| MessagingSystem.ProcessSendQueues(); |
Contributor
Author
There was a problem hiding this comment.
Is there any obvious timing issue with doing these two calls at those locations? I wonder if not doing them at a specific point in the frame could lead to knock-on effects.
ShadauxCat
approved these changes
Oct 25, 2022
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses
https://jira.unity3d.com/browse/MTT-3140
Should serve as foundation for "disconnection reasons" features, etc.