Skip to content

fix: NetworkManager property more robust on NetworkBehaviour#2257

Merged
jeffreyrainy merged 3 commits intodevelopfrom
fix/mtt-3376/load-event-complete-shutdown
Oct 19, 2022
Merged

fix: NetworkManager property more robust on NetworkBehaviour#2257
jeffreyrainy merged 3 commits intodevelopfrom
fix/mtt-3376/load-event-complete-shutdown

Conversation

@jeffreyrainy
Copy link
Copy Markdown
Contributor

@jeffreyrainy jeffreyrainy commented Oct 14, 2022

Makes the NetworkManager property more robust by checking

  • NetworkObject being null
  • Its NetworkManager being null
  • GetComponentInParent throwing an exception on null objects
  • returning NetworkManager.Singleton if all else fails

Addresses https://jira.unity3d.com/browse/MTT-3376

@jeffreyrainy jeffreyrainy marked this pull request as ready for review October 18, 2022 18:39
@jeffreyrainy jeffreyrainy requested a review from a team as a code owner October 18, 2022 18:39
@jeffreyrainy jeffreyrainy merged commit 30d23bc into develop Oct 19, 2022
@jeffreyrainy jeffreyrainy deleted the fix/mtt-3376/load-event-complete-shutdown branch October 19, 2022 18:54
jakobbbb pushed a commit to GooseGirlGames/com.unity.netcode.gameobjects that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants