fix: INetworkMessageILPP failing to output registration code for network messages#2256
Merged
NoelStephensUnity merged 10 commits intodevelopfrom Oct 13, 2022
Merged
Conversation
…t environments seem to get different results with that...
0xFA11
approved these changes
Oct 13, 2022
Collaborator
Author
|
Found out what was different about other users' environments - affected users were using |
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…ork messages (Unity-Technologies#2256) * fix Resolves the issue where NetworkMessageILPP was failing for users using different API Compatibility Settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were two issues at play here:
TypeandList<>aren't even defined in netstandard.dll anyway... so I reverted those things back to importing usingtypeof(), which should be safe and ok for system types since they don't have any differences in structure based on conditional compilation... so netstandard.dll isn't even needed anymore, but I kept the change from part 1 because it's "more correct" anyway and will prevent us from potentially hitting any future edge cases involving assemblies that have indirect references to assemblies we need to import.Testing and Documentation