refactor: Use string-based encryption APIs in UnityTransport#2238
Merged
simon-lemay-unity merged 4 commits intodevelopfrom Oct 6, 2022
Merged
refactor: Use string-based encryption APIs in UnityTransport#2238simon-lemay-unity merged 4 commits intodevelopfrom
simon-lemay-unity merged 4 commits intodevelopfrom
Conversation
ashwinimurt
approved these changes
Oct 6, 2022
johann-r-unity
approved these changes
Oct 6, 2022
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…echnologies#2238) * Add missing XML documentation * Use string-based secure APIs from UTP Co-authored-by: ashwini <36935028+ashwinimurt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that UTP 1.3 is the official dependency of NGO, we can make use of its new string-based secure settings. These are basically the exact same thing as the previous ones, except they accept strings instead of fixed strings. This PR modifies the
UnityTransportcode to make use of these new APIs, simplifying the code a little since fixed strings can be a bit cumbersome to work with.This PR also adds missing XML documentation in
UnityTransportandSecretsLoaderHelper.Also as a minor modification, the exception throw when trying to use secure WebSockets with Relay has been removed. This will be entirely handled inside UTP starting in 2.0.0-exp.8, so there won't be any need to add anything to NGO.
Changelog
N/A
Testing and Documentation