Skip to content

refactor: NetworkTransform.SetState shouldGhostsInterpolate parameter [MTT-4462] #2228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NoelStephensUnity merged 8 commits into from
Dec 2, 2022
Merged

refactor: NetworkTransform.SetState shouldGhostsInterpolate parameter [MTT-4462] #2228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e715836
refactor
NoelStephensUnity Sep 30, 2022
7faca2a
update
NoelStephensUnity Sep 30, 2022
6379c40
update
NoelStephensUnity Sep 30, 2022
6caa6ea
Merge branch 'develop' into refactor/networktransform-setstate-rename…
NoelStephensUnity Dec 1, 2022
fbfbe69
update
NoelStephensUnity Dec 1, 2022
7ffd21a
updating
NoelStephensUnity Dec 1, 2022
a923ff6
Merge branch 'develop' into refactor/networktransform-setstate-rename…
NoelStephensUnity Dec 2, 2022
f7e554b
Merge develop into refactor/networktransform-setstate-rename-shouldgh…
netcode-ci-service Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.netcode.gameobjects/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Additional documentation and release notes are available at [Multiplayer Documen
### Changed

- The default listen address of `UnityTransport` is now 0.0.0.0. (#2307)
- Renamed the NetworkTransform.SetState parameter `shouldGhostsInterpolate` to `teleportDisabled` for better clarity of what that parameter does. (#2228)

### Fixed
- Fixed server side issue where, depending upon component ordering, some NetworkBehaviour components might not have their OnNetworkDespawn method invoked if the client side disconnected. (#2323)
Expand Down
11 changes: 5 additions & 6 deletions com.unity.netcode.gameobjects/Components/NetworkTransform.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1092,10 +1092,9 @@ private void Initialize()
/// <param name="posIn"></param> new position to move to. Can be null
/// <param name="rotIn"></param> new rotation to rotate to. Can be null
/// <param name="scaleIn">new scale to scale to. Can be null</param>
/// <param name="shouldGhostsInterpolate">Should other clients interpolate this change or not. True by default</param>
/// new scale to scale to. Can be null
/// <param name="teleportDisabled">When true (the default) the <see cref="NetworkObject"/> will not be teleported and, if enabled, will interpolate. When false the <see cref="NetworkObject"/> will teleport/apply the parameters provided immediately.</param>
/// <exception cref="Exception"></exception>
public void SetState(Vector3? posIn = null, Quaternion? rotIn = null, Vector3? scaleIn = null, bool shouldGhostsInterpolate = true)
public void SetState(Vector3? posIn = null, Quaternion? rotIn = null, Vector3? scaleIn = null, bool teleportDisabled = true)
{
if (!IsSpawned)
{
Expand All @@ -1119,16 +1118,16 @@ public void SetState(Vector3? posIn = null, Quaternion? rotIn = null, Vector3? s
{
m_ClientIds[0] = OwnerClientId;
m_ClientRpcParams.Send.TargetClientIds = m_ClientIds;
SetStateClientRpc(pos, rot, scale, !shouldGhostsInterpolate, m_ClientRpcParams);
SetStateClientRpc(pos, rot, scale, !teleportDisabled, m_ClientRpcParams);
}
else // Preserving the ability for server authoritative mode to accept state changes from owner
{
SetStateServerRpc(pos, rot, scale, !shouldGhostsInterpolate);
SetStateServerRpc(pos, rot, scale, !teleportDisabled);
}
return;
}

SetStateInternal(pos, rot, scale, !shouldGhostsInterpolate);
SetStateInternal(pos, rot, scale, !teleportDisabled);
}

/// <summary>
Expand Down