fix: Issues when using UTP 2.0.0-exp.6#2224
Merged
simon-lemay-unity merged 3 commits intodevelopfrom Sep 28, 2022
Merged
Conversation
cdmazom
approved these changes
Sep 28, 2022
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
* fix: Bind to server endpoint when using Relay * Fix NativeArray conversion * Simplify creation of DataStreamReader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues that occurred if UTP 2.0.0-exp.6 was installed:
DataStreamReaderinBatchedSendQueueso that it works the same way with UTP 1.X and 2.0. This avoids an issue where the temporary native array didn't have an atomic safety handle, causing an exception when creating the stream reader.Changelog
N/A (None of the issues should be observable by users on released versions of NGO.)
Testing and Documentation