fix: Set default nonce of Relay server data to 1#2223
Merged
simon-lemay-unity merged 1 commit intodevelopfrom Sep 28, 2022
Merged
fix: Set default nonce of Relay server data to 1#2223simon-lemay-unity merged 1 commit intodevelopfrom
simon-lemay-unity merged 1 commit intodevelopfrom
Conversation
cdmazom
approved these changes
Sep 28, 2022
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before UTP 1.3 and 2.0, validation of the Relay parameters errors out if the nonce is 0. But that's a valid value (it's what the Relay team recommends we use). To avoid breakage on
developuntil we start depending on UTP 1.3, this PR sets the nonce to 1, which should pass parameter validation.Changelog
N/A (Unless users are tracking
develop, this is not an issue they would have observed.)Testing and Documentation