Skip to content

test: NetworkAnimator manual test updates for PR-2127#2205

Merged
NoelStephensUnity merged 56 commits intodevelopfrom
test/networkanimator-manual-test-updates-companion-pr-2127
Oct 4, 2022
Merged

test: NetworkAnimator manual test updates for PR-2127#2205
NoelStephensUnity merged 56 commits intodevelopfrom
test/networkanimator-manual-test-updates-companion-pr-2127

Conversation

@NoelStephensUnity
Copy link
Copy Markdown
Member

@NoelStephensUnity NoelStephensUnity commented Sep 14, 2022

This PR includes some adjustments to the NetworkAnimator manual test.
This is a companion PR to #2127. Merge after #2127 is merged.

Testing and Documentation

  • Includes manual test updates.

Vadim Tsvetkov and others added 30 commits August 11, 2022 00:40
сo-authored: Andrei Soprachev <SoprachevAK@users.noreply.github.com>
This includes coverage for running in server mode only as well as validates the fix where a second client will receive updates.
Adding changelog entry.
This fixes some additional issues with trigger synchronization.
adding comments about this change
Removed the bool from ProcessAnimationMessageQueue as it was no longer needed.
replacing the bool... (doh) ><
Needed that to mark the message processed.
Looking at the possibility of fixing the multiple trigger issue (i.e. multiple triggers are fired in the same frame on the same network animator that creates multiple transition states.
Still work in progress.  This revision adds the ability to synchronize late joining clients with more than one trigger that might have been triggered recently.  This only will be synchronized if the layer's current state hash is the same as the trigger's current or next state hash.
comments.
white space fixes.
This is a new approach to synchronizing transitions with late joining players without having to actually set the associated conditional trigger.  By building a small list of all states and then building a quick lookup table, we can just synchronize the "transition state" which for late joining clients is a cross fade between the start and destination state.  We synchronize the normalized time (where it was in the transition on the server side when the client connected) of the transition this way as well.
Now, we just synchronize states (which some can be transition states).
Updated a property name and added some network log warning and error messages.
Updating script files
Fixing issue with the PlayerPositionOffset always increasing and never just picking the first available spot.  This update should fix that issue such that if a client disconnects from a 3 or more client session then the next client that connects will fill the disconnected client's position/slot.
…workanimator-manual-test-updates-companion-pr-2127
increased number of client
Fixed issue where the late joining client was not being shutdown at the end of the LateJoinSynchronizationTest.
…workanimator-manual-test-updates-companion-pr-2127
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review September 19, 2022 18:46
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner September 19, 2022 18:46
NoelStephensUnity and others added 16 commits September 23, 2022 08:38
Since the next update will be a minor revision, removed the "if defs" and just using ISerializationCallbackReceiver.
- Removing the packing since we gain nothing unless we are packing unsigned long values.
- Caching the NetworkManager to assure we have one when cleaning up on the server side.
- Added an error message and removed TODO comment.
…workanimator-manual-test-updates-companion-pr-2127
removing some CR/LFs.
…workanimator-manual-test-updates-companion-pr-2127
re-enabled the commented out debug information when manual testing to be able to visually verify (console log) that it synchronizes a late joining client during a transition.
adding additional manual test to confirm when Animator parameters change the changes are reflected on the non-owner side and that the values remain the same after they have changed.
@NoelStephensUnity NoelStephensUnity merged commit 326bda6 into develop Oct 4, 2022
@NoelStephensUnity NoelStephensUnity deleted the test/networkanimator-manual-test-updates-companion-pr-2127 branch October 4, 2022 16:17
jakobbbb pushed a commit to GooseGirlGames/com.unity.netcode.gameobjects that referenced this pull request Feb 22, 2023
…gies#2205)

Fixes and additions to the NetworkAnimator manual tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants