Skip to content

chore: Add CI to test minimal project with different versions of transport#2190

Merged
ashwinimurt merged 2 commits intodevelopfrom
chore/add-ci-utp20
Sep 14, 2022
Merged

chore: Add CI to test minimal project with different versions of transport#2190
ashwinimurt merged 2 commits intodevelopfrom
chore/add-ci-utp20

Conversation

@ashwinimurt
Copy link
Copy Markdown
Contributor

@ashwinimurt ashwinimurt commented Sep 9, 2022

Add CI to test minimal project with different versions of transport:

  • Add a config to Pack minimal project with the dependency package version from the project.metafile, using unity-config. In this case, we have UTP 2.0.0-exp.6 for now.

  • Add a config for running upm-ci on the packed-project above.

  • Add a new Run All Compatibility Tests config

image

  • Add to Run All (trunk and non-trunk)

Changelog

None

Testing and Documentation

Verified that upm-ci log for these tests shows UTP 2.0.0-pre.6 is being used.

@ashwinimurt ashwinimurt changed the title Comment chore: add ci to test minimal project with different versions of transport Sep 9, 2022
@ashwinimurt ashwinimurt changed the title chore: add ci to test minimal project with different versions of transport chore: Add ci to test minimal project with different versions of transport Sep 9, 2022
@ashwinimurt ashwinimurt force-pushed the chore/add-ci-utp20 branch 3 times, most recently from f740af0 to c81dc7f Compare September 9, 2022 23:36
Comment thread .yamato/_run-all.yml
{% endif -%}
{% endfor -%}

## Test minimal project with different versions of dependencies
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding to RunAll - NonTrunk (runs nightly)

Comment thread .yamato/_run-all.yml
{% endif -%}
{% endfor -%}

## Test minimal project with different versions of dependencies on trunk
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding to RunAll - trunk (runs weekly)

Comment thread .yamato/_run-all.yml
{% endfor -%}

# Test minimal project with different versions of dependencies
all_compatibility_tests:
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handy Run All just for these, incase we update UTP in the future and just want to kick off these builds.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Comment thread .yamato/package-tests.yml
paths:
- "upm-ci~/test-results/**/*"
dependencies:
- .yamato/project-pack.yml#pack_{{ project.name }}_{{ dependency.name }}@{{ dependency.version }}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entire config is pretty much the same as the one above, except its dependency is a Project Packed with UTP 2.0

Comment thread .yamato/project-pack.yml
- "upm-ci~/packages/**/*"
{% endfor -%}

# Pack minimal project with different versions of dependencies
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pack minimal project with updated dependencies (UTP 2.0 in this case). This is then used by upm-ci tests in the pipeline

Comment thread .yamato/_run-all.yml
{% endif -%}
{% endfor -%}
{% endfor -%}
{% endif -%}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really liking the nested for's everywhere. Should look into changing that in the future.

@ashwinimurt ashwinimurt marked this pull request as ready for review September 9, 2022 23:58
@ashwinimurt ashwinimurt changed the title chore: Add ci to test minimal project with different versions of transport chore: Add CI to test minimal project with different versions of transport Sep 10, 2022
@ashwinimurt ashwinimurt enabled auto-merge (squash) September 14, 2022 15:32
@ashwinimurt ashwinimurt merged commit 43218a3 into develop Sep 14, 2022
@ashwinimurt ashwinimurt deleted the chore/add-ci-utp20 branch September 14, 2022 16:21
jakobbbb pushed a commit to GooseGirlGames/com.unity.netcode.gameobjects that referenced this pull request Feb 22, 2023
…sport (Unity-Technologies#2190)

chore: add ci to test minimal project with different versions of transport
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants