fix: Use Time.unscaledDeltaTime instead of Time.deltaTime as time step (#2171)#2183
Closed
PitouGames wants to merge 1 commit intoUnity-Technologies:developfrom
Closed
fix: Use Time.unscaledDeltaTime instead of Time.deltaTime as time step (#2171)#2183PitouGames wants to merge 1 commit intoUnity-Technologies:developfrom
PitouGames wants to merge 1 commit intoUnity-Technologies:developfrom
Conversation
Unity-Technologies#2171) This fixes the case of Time.timeScale = 0 stopping the NetworkManager to update. This as no influence on all projects that always have Time.timeScale = 1. + Add tests + Change existing test using Assert.Equal(boolExpr) to the correct Assert function to display real values expected instead of just "true" or "false"
|
|
Contributor
|
Our CI pipeline requires PR to be from the dev team. I've merged it into Thanks for the quality work, including tests and changelog! |
Contributor
|
After adjustments, this was merged in as #2187 Thanks! that was a good PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the case of Time.timeScale = 0 that stops the NetworkManager to send updates.
It only change the NetworkManager to use
Time.unscaledDeltaTimeinstead ofTime.deltaTime(scaled) when advancing the time system.It has no influence on all projects that always use Time.timeScale = 1.
Changelog
Time.timeScaleis set to 0 #2171)Testing and Documentation