style: fixing the 'tools' part of the SDK to pass standards checks.#2177
Merged
jeffreyrainy merged 1 commit intodevelopfrom Sep 1, 2022
Merged
style: fixing the 'tools' part of the SDK to pass standards checks.#2177jeffreyrainy merged 1 commit intodevelopfrom
jeffreyrainy merged 1 commit intodevelopfrom
Conversation
0xFA11
approved these changes
Sep 1, 2022
simon-lemay-unity
approved these changes
Sep 1, 2022
| namespace Unity.Netcode | ||
| { | ||
| class NetworkObjectProvider : INetworkObjectProvider | ||
| internal class NetworkObjectProvider : INetworkObjectProvider |
Contributor
There was a problem hiding this comment.
I can't help but ask this again - are we ever going to support unity's coding standards? Practically everywhere else that c# code is written, you're not supposed to add extraneous access modifiers. (Not blocking this PR with this question ofc)
becksebenius-unity
approved these changes
Sep 1, 2022
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding the tools packages, some parts of Netcode for GameObjects fail our standards check. This is due to code that is ifdef'ed out.
This PR addresses these stylistic concerns, without changing the functionality.