Performance Improvement#2176
Performance Improvement#2176smitdylan2001 wants to merge 3 commits intoUnity-Technologies:developfrom
Conversation
- Merge if else into return - Merge .rotation and .position into .SetPositionAndRotation - Remove .ToString() call on strings - Use TryGetComponent to reduce garbage allocation - Merge .Where().Count() calls into .Count() call - Remove indirect gameObject call - Remove redundant null check - Use native .Count instead of LINQ method - Use faster string comparison
|
|
|
thank you for the PR! I think we could review and get these minor improvements — perhaps we should consider putting that into the sprint? @JesseOlmer |
|
These are nice small details that affects impacts of performance improvements, especially GC one. Is it going to be approved? |
|
so here's an update: I had a quick chat with the team. there are a few updates we're making around the same area atm — we think we'll get back to this after merging those other changes and merging |
|
Tracked internally with MTT-4641. |
|
Thank you for the submission! I'll be using #2204 to check that it passes our CI and will review there. |
Should be up to date with the latest master |
|
Merged as #2204 (pending CI) Thanks for the improvements! |
* Performance Improvement - Merge if else into return - Merge .rotation and .position into .SetPositionAndRotation - Remove .ToString() call on strings - Use TryGetComponent to reduce garbage allocation - Merge .Where().Count() calls into .Count() call - Remove indirect gameObject call - Remove redundant null check - Use native .Count instead of LINQ method - Use faster string comparison * style: adjusting to code standards Co-authored-by: smitdylan2001 <dylan.smit01@gmail.com>
…y-Technologies#2204) * Performance Improvement - Merge if else into return - Merge .rotation and .position into .SetPositionAndRotation - Remove .ToString() call on strings - Use TryGetComponent to reduce garbage allocation - Merge .Where().Count() calls into .Count() call - Remove indirect gameObject call - Remove redundant null check - Use native .Count instead of LINQ method - Use faster string comparison * style: adjusting to code standards Co-authored-by: smitdylan2001 <dylan.smit01@gmail.com>
Changelog
Testing and Documentation
No functionality changed