chore: UTP Transport 2.0 support [MTT-4473]#2162
Merged
jeffreyrainy merged 19 commits intodevelopfrom Aug 31, 2022
Merged
Conversation
…P Transport is 2.0 or above
…P Transport is 2.0 or above
…/com.unity.netcode.gameobjects into chore/utp-2.0-support
…hen UTP Transport is 2.0 or above
…/com.unity.multiplayer.mlapi into chore/utp-2.0-support
Contributor
|
I would test with the tools package installed. It triggers some code to be compiled which also needs to be updated for UTP 2.0. Off the top of my head:
|
0xFA11
reviewed
Aug 30, 2022
0xFA11
approved these changes
Aug 30, 2022
Contributor
Author
Contributor
Author
|
…bjects, with UTP 2.0
…bjects, with UTP 2.0
…/com.unity.netcode.gameobjects into chore/utp-2.0-support
simon-lemay-unity
approved these changes
Aug 30, 2022
Contributor
Author
Ok, I fixed that. The latest commits allow building and running with tools. One test had to be disabled, but @Rosme is aware and OK with that. |
becksebenius-unity
suggested changes
Aug 30, 2022
ashwinimurt
approved these changes
Aug 31, 2022
becksebenius-unity
approved these changes
Aug 31, 2022
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
* chore: adding preprocessor define in Netcode for GameObjects, when UTP Transport is 2.0 or above * chore: adding preprocessor define in Netcode for GameObjects, when UTP Transport is 2.0 or above * chore: adding preprocessor define in Netcode for GameObjects tests, when UTP Transport is 2.0 or above * chore: conditional use of UTP 2.0 * style: coding standards * style: coding standards * Adding some fixed from PR review comment * fix: fixing tools package compilation, when used in netcode for gameobjects, with UTP 2.0 * fix: fixing tools package compilation, when used in netcode for gameobjects, with UTP 2.0 * fix: build break for UTP 2.0 builds without tools installed * fix: fixing build errors with Collection 2.1.0-exp3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds conditional compilation checks and adjustments to support both UTP and UTP 2.0
MTT-4473