Skip to content

fix: Corrects memory leak in MessageRegistrationTests #2148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NoelStephensUnity merged 1 commit into from
Aug 24, 2022
Merged

fix: Corrects memory leak in MessageRegistrationTests #2148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions com.unity.netcode.gameobjects/Tests/Editor/Messaging/MessageRegistrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,9 @@ public void WhenCreatingMessageSystem_OnlyProvidedTypesAreRegistered()
{
var sender = new NopMessageSender();

var systemOne = new MessagingSystem(sender, null, new TestMessageProviderOne());
var systemTwo = new MessagingSystem(sender, null, new TestMessageProviderTwo());
var systemThree = new MessagingSystem(sender, null, new TestMessageProviderThree());
using var systemOne = new MessagingSystem(sender, null, new TestMessageProviderOne());
using var systemTwo = new MessagingSystem(sender, null, new TestMessageProviderTwo());
using var systemThree = new MessagingSystem(sender, null, new TestMessageProviderThree());

using (systemOne)
using (systemTwo)
Expand All @@ -161,9 +161,9 @@ public void WhenCreatingMessageSystem_BoundTypeMessageHandlersAreRegistered()
{
var sender = new NopMessageSender();

var systemOne = new MessagingSystem(sender, null, new TestMessageProviderOne());
var systemTwo = new MessagingSystem(sender, null, new TestMessageProviderTwo());
var systemThree = new MessagingSystem(sender, null, new TestMessageProviderThree());
using var systemOne = new MessagingSystem(sender, null, new TestMessageProviderOne());
using var systemTwo = new MessagingSystem(sender, null, new TestMessageProviderTwo());
using var systemThree = new MessagingSystem(sender, null, new TestMessageProviderThree());

using (systemOne)
using (systemTwo)
Expand Down Expand Up @@ -235,7 +235,7 @@ public void MessagesGetPrioritizedCorrectly()
{
var sender = new NopMessageSender();
var provider = new OrderingMessageProvider();
var messagingSystem = new MessagingSystem(sender, null, provider);
using var messagingSystem = new MessagingSystem(sender, null, provider);

// the 3 priority messages should appear first, in lexicographic order
Assert.AreEqual(messagingSystem.MessageTypes[0], typeof(ConnectionApprovedMessage));
Expand Down