Skip to content

fix: TransformInterpolationTests Threshold Adjustment #2145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NoelStephensUnity merged 3 commits into from
Aug 24, 2022
Merged

fix: TransformInterpolationTests Threshold Adjustment #2145

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71f1929
fix
NoelStephensUnity Aug 24, 2022
85bc26b
style
NoelStephensUnity Aug 24, 2022
d186511
Merge branch 'develop' into fix/transforminterpolationtests-threshold…
NoelStephensUnity Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions com.unity.netcode.gameobjects/Tests/Runtime/TransformInterpolationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace Unity.Netcode.RuntimeTests
public class TransformInterpolationObject : NetworkBehaviour
{
// Set the minimum threshold which we will use as our margin of error
public const float MinThreshold = 0.001f;
public const float MinThreshold = 0.005f;

public bool CheckPosition;
public bool IsMoving;
Expand All @@ -24,7 +24,7 @@ private void Update()
{
if (transform.position.y < -MinThreshold || transform.position.y > 100.0f + MinThreshold)
{
Debug.LogError($"Interpolation failure. transform.position.y is {transform.position.y}. Should be between 0.0 and 100.0");
Debug.LogError($"Interpolation failure. transform.position.y is {transform.position.y}. Should be between 0.0 and 100.0. Current threshold is [+/- {MinThreshold}].");
}
}

Expand Down