fix: prevent exception in Boss Room with NetworkAnimator #2140
Merged
jeffreyrainy merged 2 commits intodevelopfrom Aug 22, 2022
Merged
fix: prevent exception in Boss Room with NetworkAnimator #2140jeffreyrainy merged 2 commits intodevelopfrom
jeffreyrainy merged 2 commits intodevelopfrom
Conversation
…workBehaviour being null
Contributor
Author
|
@ashwinimurt This will come up in Boss Room testing if not merged in. We still need some work to understand why it is needed, but at least it removes the exception. |
ashwinimurt
approved these changes
Aug 22, 2022
JesseOlmer
approved these changes
Aug 22, 2022
Contributor
JesseOlmer
left a comment
There was a problem hiding this comment.
lgtm. Please make sure there's a JIRA issue to track the long term fix/investigation
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…ologies#2140) fix: prevent exception in Boss Room with NetworkAnimator due to m_NetworkBehaviour being null
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents an exception in Boss Room with NetworkAnimator due to
m_NetworkBehaviourbeing nullFollowing a previous change for performance, a null exception is raised in Boss Room. This works around it.