fix: fail to synchronize animation state in owner authoritative mode#2133
Closed
superztf wants to merge 1 commit intoUnity-Technologies:developfrom
Closed
fix: fail to synchronize animation state in owner authoritative mode#2133superztf wants to merge 1 commit intoUnity-Technologies:developfrom
superztf wants to merge 1 commit intoUnity-Technologies:developfrom
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using NetworkAnimator by owner authoritative(not server authoritative) has some problems with synchronizing animation state, parameters and trigger.
Especially synchronizing animation state,
NetworkAnimatorStateChangeHandler.FlushMessagesmissed checkingm_SendAnimationUpdates.On the other hand, the condition
NetworkManager.ConnectedClientsIds.Count - 2 > 0to judge broadcast animation info(state, parameters, trigger) was not correct.NetworkManager.ServerClientIdis not a element ofNetworkManager.ConnectedClientsIds.So NetworkAnimator cannot work by owner authoritative way.
By the way, I read Pull Request Submission Guidelines, But I am still not really sure how to participate in contributing and I can't log in to https://jira.unity3d.com/
I would like to be informed of the detailed steps.
Changelog
Testing and Documentation