Skip to content

fix: fail to synchronize animation state in owner authoritative mode#2133

Closed
superztf wants to merge 1 commit intoUnity-Technologies:developfrom
superztf:fix/sync-animstate-by-owner-authoritative
Closed

fix: fail to synchronize animation state in owner authoritative mode#2133
superztf wants to merge 1 commit intoUnity-Technologies:developfrom
superztf:fix/sync-animstate-by-owner-authoritative

Conversation

@superztf
Copy link
Copy Markdown

Using NetworkAnimator by owner authoritative(not server authoritative) has some problems with synchronizing animation state, parameters and trigger.
Especially synchronizing animation state, NetworkAnimatorStateChangeHandler.FlushMessages missed checking m_SendAnimationUpdates.
On the other hand, the condition NetworkManager.ConnectedClientsIds.Count - 2 > 0 to judge broadcast animation info(state, parameters, trigger) was not correct. NetworkManager.ServerClientId is not a element of NetworkManager.ConnectedClientsIds.

So NetworkAnimator cannot work by owner authoritative way.

By the way, I read Pull Request Submission Guidelines, But I am still not really sure how to participate in contributing and I can't log in to https://jira.unity3d.com/
I would like to be informed of the detailed steps.

Changelog

  • Fixed: Synchronize animation state in owner authoritative mode

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

@superztf superztf requested a review from a team as a code owner August 18, 2022 13:25
@unity-cla-assistant
Copy link
Copy Markdown

unity-cla-assistant commented Aug 18, 2022

CLA assistant check
All committers have signed the CLA.

@NoelStephensUnity
Copy link
Copy Markdown
Member

Hello @superztf !
Thank you for your contribution.
PR-2127 addresses this issue so I am closing out this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants