fix: MessageSendingTests causing memory leak during editor tests.#2125
Merged
NoelStephensUnity merged 3 commits intodevelopfrom Aug 16, 2022
Merged
fix: MessageSendingTests causing memory leak during editor tests.#2125NoelStephensUnity merged 3 commits intodevelopfrom
NoelStephensUnity merged 3 commits intodevelopfrom
Conversation
0xFA11
reviewed
Aug 15, 2022
0xFA11
reviewed
Aug 16, 2022
0xFA11
approved these changes
Aug 16, 2022
…ndingTests.cs Adding Fatih's LF/CR suggestion for readability Co-authored-by: Fatih Mar <mfatihmar@gmail.com>
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…ity-Technologies#2125) * fix Seeing if this fixes the issue with our memory leaks. * fix minor fix to my fix. Need to reconnect the client after creating the new MessagingSystem. adjusted a comment. * Update com.unity.netcode.gameobjects/Tests/Editor/Messaging/MessageSendingTests.cs Adding Fatih's LF/CR suggestion for readability Co-authored-by: Fatih Mar <mfatihmar@gmail.com> Co-authored-by: Fatih Mar <mfatihmar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issues with the memory leak failing in the editor tests.