Fix client authoritive NetworkAnimator

[florius0]

When synchronising Animator with NetworkAnimator component the second client (if number of clients is greater than 2) was not synchronised when IsServerAuthoritive() is false.

Changelog

• Fixed: NetworkAnimator was not synced correctly for second client when not server-authoritive.

Testing and Documentation

• No tests have been added.
• No documentation changes or additions were necessary.

[unity-cla-assistant]

All committers have signed the CLA.

[NoelStephensUnity]

I see...yes that is a good catch indeed!
How about we condense that to something like:

                if (NetworkManager.ConnectedClientsIds.Count > (IsHost ? 2 : 1) )
                {

Thank you for your contribution and taking the time to troubleshoot that! 👍

[florius0]

Can do, but isn't it more clear as it is?

[NoelStephensUnity]

Well...with your current suggested fix you could still have a Host with one connected client and it would pass the conditional "If" check. My update to your suggestion assures that if it is a Host it requires more than 2 connected clients, otherwise if it is server it only requires one.
Does that make sense?

[florius0]

Indeed, we overlooked it

[SoprachevAK]

Done.

[NoelStephensUnity]

This PR was brought into the build pipeline via PR-2127. Closing this PR now that it has been processed internally.

[NoelStephensUnity]

@florius0
I found some other issues that prevented the PR from making it into the coming patch.
If you are blocked, you can always use the fix/client-authoritative-networkanimator branch until it is merged.
There is an edge case (or less frequent) scenario I need to make some adjustments for on that branch. So, unless you set multiple triggers at the same time on the same Animator that start multiple transition states it should work fine. 👍

[florius0]

Thank you. We are currently using our fork cherry-picked on v1.0.0 and we'll watch for it in our project