Skip to content

feat: host tells client which IDs it uses for INetworkMessages#2103

Merged
JesseOlmer merged 16 commits intodevelopfrom
feat/message-id-ordering
Aug 8, 2022
Merged

feat: host tells client which IDs it uses for INetworkMessages#2103
JesseOlmer merged 16 commits intodevelopfrom
feat/message-id-ordering

Conversation

@jeffreyrainy
Copy link
Copy Markdown
Contributor

Adds a synchronization mechanism so that host tells client which IDs it uses for INetworkMessages. When there's discrepancies, allows the client to adjust its mapping.

Makes our SDK generally more robust.

Also necessary for https://jira.unity3d.com/browse/MTT-4166 since 2022.2 has different classes visible in some scenario.

@jeffreyrainy jeffreyrainy marked this pull request as ready for review August 3, 2022 23:52
@jeffreyrainy jeffreyrainy requested a review from a team as a code owner August 3, 2022 23:52
Comment thread com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs Outdated
Comment thread com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs Outdated
Comment thread com.unity.netcode.gameobjects/Runtime/Messaging/MessagingSystem.cs Outdated
0xFA11
0xFA11 previously requested changes Aug 4, 2022
Copy link
Copy Markdown
Contributor

@0xFA11 0xFA11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented inline

@jeffreyrainy jeffreyrainy requested a review from 0xFA11 August 4, 2022 18:07
@jeffreyrainy jeffreyrainy force-pushed the feat/message-id-ordering branch from 22e45ee to fc0cd45 Compare August 4, 2022 18:27
Comment thread com.unity.netcode.gameobjects/Runtime/Messaging/MessagingSystem.cs Outdated
Comment thread com.unity.netcode.gameobjects/Runtime/Messaging/MessagingSystem.cs
Comment thread com.unity.netcode.gameobjects/Runtime/Messaging/MessagingSystem.cs Outdated
Comment thread com.unity.netcode.gameobjects/Runtime/Messaging/MessagingSystem.cs Outdated
Comment thread com.unity.netcode.gameobjects/Runtime/Messaging/MessagingSystem.cs
Comment thread com.unity.netcode.gameobjects/Tests/Editor/Messaging/MessageRegistrationTests.cs Outdated
Comment thread com.unity.netcode.gameobjects/Runtime/Messaging/MessagingSystem.cs
Comment thread com.unity.netcode.gameobjects/Runtime/Messaging/MessagingSystem.cs
Comment thread com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs
@jeffreyrainy jeffreyrainy requested a review from JesseOlmer August 5, 2022 15:05
@0xFA11 0xFA11 dismissed their stale review August 5, 2022 19:38

addressed

@jeffreyrainy jeffreyrainy requested a review from JesseOlmer August 5, 2022 20:52
Comment thread com.unity.netcode.gameobjects/Runtime/Messaging/MessagingSystem.cs
@jeffreyrainy jeffreyrainy requested a review from JesseOlmer August 8, 2022 14:07
Copy link
Copy Markdown
Contributor

@JesseOlmer JesseOlmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JesseOlmer JesseOlmer merged commit 421a364 into develop Aug 8, 2022
@JesseOlmer JesseOlmer deleted the feat/message-id-ordering branch August 8, 2022 19:43
jakobbbb pushed a commit to GooseGirlGames/com.unity.netcode.gameobjects that referenced this pull request Feb 22, 2023
…-Technologies#2103)

Server sends client reordering messages when host and client have different sets to ensure proper handler mappings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants