Skip to content

fix: NetworkList "insert at end" bug#2099

Merged
0xFA11 merged 4 commits intodevelopfrom
fix/network-list-insert-at-end
Aug 3, 2022
Merged

fix: NetworkList "insert at end" bug#2099
0xFA11 merged 4 commits intodevelopfrom
fix/network-list-insert-at-end

Conversation

@jeffreyrainy
Copy link
Copy Markdown
Contributor

NetworkList using NativeList.Add() instead of InsertRangeWithBeginEnd when inserting at end of container

Reported:
https://discord.com/channels/449263083769036810/994598309647888504/1002543855335374891

Changelog

  • Fixed NetworkList issue that showed when inserting at the very end of a NetworkList

…BeginEnd when inserting at end of container (changelog)
@jeffreyrainy jeffreyrainy requested a review from a team as a code owner August 3, 2022 03:00
Comment thread com.unity.netcode.gameobjects/CHANGELOG.md Outdated
@0xFA11 0xFA11 enabled auto-merge (squash) August 3, 2022 21:10
Copy link
Copy Markdown
Member

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@0xFA11 0xFA11 disabled auto-merge August 3, 2022 23:01
@0xFA11 0xFA11 merged commit 8bac8aa into develop Aug 3, 2022
@0xFA11 0xFA11 deleted the fix/network-list-insert-at-end branch August 3, 2022 23:01
jakobbbb pushed a commit to GooseGirlGames/com.unity.netcode.gameobjects that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants