fix: client owner with both owner read and write permissions on a NetworkVariable does not update the server when changed#2097
Merged
NoelStephensUnity merged 7 commits intodevelopfrom Aug 9, 2022
Conversation
…t-updating-server
jeffreyrainy
approved these changes
Aug 3, 2022
…t-updating-server
…t-updating-server
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…workVariable does not update the server when changed (Unity-Technologies#2097) * fix MTT-4266 This fixes the issue where a NetworkVariable that is set to owner read and write permissions and the owner is a client, then the server would not be updated with any changes to the NetworkVariable. * test This includes an additional test to check that a client owner with both Owner read and write permissions will only update changes to the NetworkVariable on the server. * update Adding the changelog entry for this fix. * update adding PR number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue where a client owner with owner read and write permissions was not updating the server side when the client owner changed the
NetworkVariable.Value.MTT-4266
GitHub Issue #2094
Changelog
Testing and Documentation