fix: NetworkAnimator fails to synchronize end of animation loop for late joining clients [MTT-4060]#2076
Merged
JesseOlmer merged 12 commits intodevelopfrom Jul 27, 2022
Conversation
This includes the integration validation test for the fix. This includes an additional internal action to handle capturing AnimationMessages sent and received. This also includes adjustments to the components assembly info to assure that the internal properties are available during a runtime test runner build (i.e. consoles).
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…ate joining clients [MTT-4060] (Unity-Technologies#2076) This resolves the issue where animations at the end of their loop would not be synchronized with late joining clients.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves the issue where NetworkAnimator didn't properly synchronize late joining clients when a looping animation state was at the end of its loop.
MTT-4060
Based on Github Issue #2056
Changelog
NetworkAnimatorwould not synchronize a looping animation for late joining clients if it was at the very end of its loop.Testing and Documentation
Additional Notes:
The assets updated are required for the test.