fix: updating testproject NetworkAnimator test#2075
Merged
Conversation
jeffreyrainy
approved these changes
Jul 27, 2022
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
* fix This resolves the issue with NetworkAnimator not de-registering itself from OnClientConnected. This resolves some issues with the manual NetworkAnimator test. * update MTT-4080 (this branch includes fixes for the OnClientConnectedCallback issue) Renamed NetworkAnimatorEnhancement scene to NetworkAnimatorServerOwnerTest. Adding the manual NetworkAnimatorServerOwnerTest scene to the scenes in build list. * style fixing whitespace issue. * update Fixing how AnimatedCubeController determines the type of NetworkAnimator and whether it is server or owner authoritative. * update Simplifying the conditional check requirements down to IsSpawned and IsOwner for the AnimationUserInput component since the only input checked should always be by the owner. * update removing an artifact from cherry picking a previous branch's work that included the manual test fixes. * style removing unused property.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some issues found with the manual test of NetworkAnimator.
This includes the renaming of the manual test scene name to a more pertinent name.
Testing and Documentation