Skip to content

fix: Actually documenting the change from 'OnIsServerAuthoritatitive' to 'OnIsServerAuthoritative' in NetworkTransform #2039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
11BelowStudio wants to merge 5 commits into from
Closed

fix: Actually documenting the change from 'OnIsServerAuthoritatitive' to 'OnIsServerAuthoritative' in NetworkTransform #2039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f4ab906
Properly documented the change from 'OnIsServerAuthoritatitive' to 'O…
11BelowStudio Jun 23, 2022
8b527b4
making the deprecated method call the non-deprecated method.
11BelowStudio Jun 23, 2022
69e239c
added the reason for OnIsServerAuthoritatitive deprecation.
11BelowStudio Jun 23, 2022
2af8117
added a UnityUpgradable thing to the obsolete tag on the old method
11BelowStudio Jun 23, 2022
6a36d26
Update NetworkTransform.cs
11BelowStudio Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.netcode.gameobjects/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ Additional documentation and release notes are available at [Multiplayer Documen

- Updated `UnityTransport` dependency on `com.unity.transport` to 1.1.0. (#2025)
- (API Breaking) `ConnectionApprovalCallback` is no longer an `event` and will not allow more than 1 handler registered at a time. Also, `ConnectionApprovalCallback` is now a `Func<>` taking `ConnectionApprovalRequest` in and returning `ConnectionApprovalResponse` back out (#1972)
- (API Breaking) `NetworkTransform.OnIsServerAuthoritatitive` is now obsolete. Use `NetworkTransform.OnIsServerAuthoritative` instead. (typo in original method name)

### Removed

Expand Down
11 changes: 11 additions & 0 deletions com.unity.netcode.gameobjects/Components/NetworkTransform.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,6 +942,17 @@ public void Teleport(Vector3 newPosition, Quaternion newRotation, Vector3 newSca
m_LocalAuthoritativeNetworkState.IsTeleportingNextFrame = false;
}


/// <summary>
/// Please override <see cref="OnIsServerAuthoritative"/> instead (typo in this method's name).
/// Do not use this method as of v1.0.0.pre-10
/// </summary>
[System.Obsolete("Method OnIsServerAuthoritatitive has been deprecated. Use OnIsServerAuthoritative instead (UnityUpgradable)", true)]
[System.ComponentModel.EditorBrowsable(System.ComponentModel.EditorBrowsableState.Never)]
protected bool OnIsServerAuthoritatitive(){
throw new NotSupportedException("OnIsServerAuthoritatitive method has been deprecated.");
}

/// <summary>
/// Override this method and return false to switch to owner authoritative mode
/// </summary>
Expand Down