Conversation
| private NetworkPipeline m_ReliableSequencedPipeline; | ||
|
|
||
| /// <summary> | ||
| /// The client id used to represent the server. |
There was a problem hiding this comment.
Might want to add a note that this uses the "transport ID" of the client. It doesn't match the client IDs that users are normally handling.
There was a problem hiding this comment.
On second thought maybe it's not worth mentioning it. Every client ID handled in this file is a "transport ID". Making a note only here could lead someone to think other uses of client IDs are not "transport IDs".
| } | ||
|
|
||
| /// <summary> | ||
| /// Send a payload to the specified clientId, data and channelName. |
There was a problem hiding this comment.
Channel name is inaccurate. Only delivery types are used now.
There was a problem hiding this comment.
True, but this was copied from the underlying Transport.cs, so that's probably where the fix should be made primarly.
There was a problem hiding this comment.
This is because the inheritdoc tag that is super useful is not supported basically anywhere. So copy paste has to be done.
There was a problem hiding this comment.
so, fix them in both places?
|
Closed and continued in #2026 |
No description provided.