Skip to content

test: Limit platforms until all the other platforms are ready #2021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xFA11 merged 3 commits into from
Jun 16, 2022
Merged

test: Limit platforms until all the other platforms are ready #2021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2403a5
Limit platforms until all the other platforms are ready
zain-mecklai Jun 15, 2022
5de5a3e
Follow up from code review from previous PR where this was commented …
zain-mecklai Jun 15, 2022
8939715
Merge with develop
zain-mecklai Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions testproject/Assets/Tests/Runtime/MultiprocessRuntime/TestCoordinator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,10 @@ public void Awake()
}


// if we've tried all the configuration types and none of them are correct then we should throw an exception
// if we've tried all the configuration types and none of them are correct then we should log it and just go with the default values
if (ConfigurationType == ConfigurationType.Unknown)
{
// throw new Exception("Unable to determine configuration for NetworkManager via commandline, webapi or config file");
MultiprocessLogger.Log("Unable to determine configuration for NetworkManager via commandline, webapi or config file");
}

if (Instance != null)
Expand Down
8 changes: 7 additions & 1 deletion testproject/Assets/Tests/Runtime/MultiprocessRuntime/testproject.multiprocesstests.asmdef
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,13 @@
"UnityEngine.TestRunner",
"UnityEditor.TestRunner"
],
"includePlatforms": [],
"includePlatforms": [
"Editor",
"macOSStandalone",
"LinuxStandalone64",
"WindowsStandalone32",
"WindowsStandalone64"
],
"excludePlatforms": [],
"allowUnsafeCode": true,
"overrideReferences": false,
Expand Down