Skip to content

test: Update asmdef for the tests to match the product#2016

Merged
0xFA11 merged 7 commits intodevelopfrom
test/unet-utp-support-multiprocess-tests
Jun 15, 2022
Merged

test: Update asmdef for the tests to match the product#2016
0xFA11 merged 7 commits intodevelopfrom
test/unet-utp-support-multiprocess-tests

Conversation

@zain-mecklai
Copy link
Copy Markdown
Contributor

@zain-mecklai zain-mecklai commented Jun 14, 2022

Updated the testproject for multi-process tests to define UNITY_UNET_PRESENT
Switched to UTP as default transport for test run
Set the default port to 7777 so that client and server are synced. This will changed to a more flexible solution in a future PR.

@zain-mecklai zain-mecklai requested a review from 0xFA11 as a code owner June 14, 2022 16:21
@zain-mecklai zain-mecklai changed the title tests: Update asmdef for the tests to match the product test: Update asmdef for the tests to match the product Jun 14, 2022
@ashwinimurt
Copy link
Copy Markdown
Contributor

Need formatting fix, and commit message.

@zain-mecklai zain-mecklai requested a review from a team as a code owner June 14, 2022 17:51
@0xFA11 0xFA11 enabled auto-merge (squash) June 14, 2022 18:52
if (ConfigurationType == ConfigurationType.Unknown)
{
throw new Exception("Unable to determine configuration for NetworkManager via commandline, webapi or config file");
// throw new Exception("Unable to determine configuration for NetworkManager via commandline, webapi or config file");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this stay commented?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit ^^^

@0xFA11 0xFA11 merged commit 20304f1 into develop Jun 15, 2022
@0xFA11 0xFA11 deleted the test/unet-utp-support-multiprocess-tests branch June 15, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants