fix: Clear UnityTransport reliable receive queues on shutdown#2011
Merged
fix: Clear UnityTransport reliable receive queues on shutdown#2011
Conversation
johann-r-unity
approved these changes
Jun 13, 2022
0xFA11
approved these changes
Jun 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
UnityTransportwas shut down and then the same instance of the object was re-initialized, it was possible to reuse the previous reliable receive queues. This could have caused corruption of the data stream if an incomplete message was stored inside those queues.This might fix MTT-3685, but it's very much a stretch. In fact, I'm not sure this fix is actually addressing something that ever was a problem to begin with. I'm submitting the fix more for completeness's sake than anything.
Changelog
N/A (Didn't think it was worthy of a changelog entry.)
Testing and Documentation