feat: Add "RemoveNetworkPrefab" which is necessary for certain addressables implementations#1950
Merged
ShadauxCat merged 8 commits intodevelopfrom May 18, 2022
Merged
Conversation
…sables implementations
0xFA11
reviewed
May 9, 2022
| } | ||
| } | ||
|
|
||
| public void RemoveNetworkPrefab(GameObject prefab) |
Contributor
There was a problem hiding this comment.
I'll add tests and in another commit.
why not in this PR?
Collaborator
Author
There was a problem hiding this comment.
It'll be in this PR, I just haven't done it yet.
Collaborator
Author
There was a problem hiding this comment.
I'm trying getting the PR up without tests first so people can start reviewing it while I write the tests. Thought it'd be a little more parallelizable that way.
- Enforced not removing prefabs when ForceSamePrefabs is enabled.
0xFA11
reviewed
May 10, 2022
|
|
||
| ### Added | ||
|
|
||
| - Added `NetworkManager.RemoveNetworkPrefab(...)` to remove a prefab from the prefabs list (#1950) |
Contributor
There was a problem hiding this comment.
just a note that this PR will also be considered for backport to release/1.0.0 for 1.0.0-pre.10
0xFA11
approved these changes
May 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered in scenario week: For Addressables use cases that involve dynamically loading and unloading things to keep the memory footprint low, the lack of a
RemoveNetworkPrefabmakes it impossible to unload them properly.Changelog
NetworkManager.RemoveNetworkPrefabto remove a prefab from the prefabs listTesting and Documentation
I'll add tests in another commit to be added to this PR soon.