fix: cleaning up connected clients upon shutdown [MTT-1573] (backport #1945)#1949
Merged
0xFA11 merged 5 commits intorelease/1.0.0from May 9, 2022
Merged
fix: cleaning up connected clients upon shutdown [MTT-1573] (backport #1945)#19490xFA11 merged 5 commits intorelease/1.0.0from
0xFA11 merged 5 commits intorelease/1.0.0from
Conversation
0xFA11
reviewed
May 9, 2022
| - Fixed: Hosting again after failing to host now works correctly | ||
|
|
||
| - Fixed NetworkManager to cleanup connected client lists after stopping (#1945) | ||
| - Fixed: NetworkHide followed by NetworkShow on the same frame works correctly (#1940) |
0xFA11
approved these changes
May 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of:
This cleans up the connected clients upon shutdown. Proper clean-up.
Doesn't change much for the customers, though, since recent Netcode for GameObjects would throw an exception, anyway, if trying to access connected clients while not hosting.
#416