fix: allowing quick NetworkHide and NetworkShow [MTT-3488]#1944
Merged
jeffreyrainy merged 3 commits intodevelopfrom May 9, 2022
Merged
fix: allowing quick NetworkHide and NetworkShow [MTT-3488]#1944jeffreyrainy merged 3 commits intodevelopfrom
jeffreyrainy merged 3 commits intodevelopfrom
Conversation
0xFA11
approved these changes
May 8, 2022
0xFA11
suggested changes
May 8, 2022
Contributor
0xFA11
left a comment
There was a problem hiding this comment.
and a test to verify behavior? :)
Contributor
Author
Done. |
Contributor
Author
Yep, changelog added. Backport, for sure, but it's easier to do it as a second PR once this is merged. |
0xFA11
reviewed
May 9, 2022
| Show(mode == 0, false); | ||
| Show(mode == 0, true); | ||
|
|
||
| yield return new WaitForSeconds(0.5f); |
Contributor
There was a problem hiding this comment.
perhaps waitforticks (network) instead of waitforseconds?
Contributor
Author
There was a problem hiding this comment.
None of the options are correct. Both underscore the underlying issues with our tests setup. But yeah, I can change it if you prefer. I guess 5 ticks ought to be enough.
Contributor
Author
There was a problem hiding this comment.
Also, done using ticks :-)
0xFA11
approved these changes
May 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifies which object got OnDestroyed, to prevent confusion on quick NetworkHide and NetworkShow.
Addresses #1940