Skip to content

chore: Separate trunk tests and trigger weekly #1926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashwinimurt merged 4 commits into from
May 4, 2022
Merged

chore: Separate trunk tests and trigger weekly #1926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
093dd29
chore: Separate trunk tests and trigger weekly
ashwinimurt May 3, 2022
eac1dcc
Rename to weekly
ashwinimurt May 3, 2022
db3af9a
Turn off badges trigger dependencies on trunk
ashwinimurt May 3, 2022
ef8a00a
Run Code Coverage on validation_editor 2020.3
ashwinimurt May 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .yamato/_run-all.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,28 @@ run_all_tests:
{% for platform in test_platforms -%}
{% for project in projects -%}
{% for editor in project.test_editors -%}
{% if editor != "trunk" -%}
{% for package in project.packages -%}
- .yamato/package-tests.yml#test_{{ project.name}}_{{ package.name }}_{{ editor }}_{{ platform.name }}
{% endfor -%}
- .yamato/project-tests.yml#test_{{ project.name }}_{{ editor }}_{{ platform.name }}
{% endif -%}
{% endfor -%}
{% endfor -%}
{% endfor -%}

run_all_tests_trunk:
name: Run All Package and Project Tests [Trunk]
dependencies:
{% for platform in test_platforms -%}
{% for project in projects -%}
{% for editor in project.test_editors -%}
{% if editor == "trunk" -%}
{% for package in project.packages -%}
- .yamato/package-tests.yml#test_{{ project.name}}_{{ package.name }}_{{ editor }}_{{ platform.name }}
{% endfor -%}
- .yamato/project-tests.yml#test_{{ project.name }}_{{ editor }}_{{ platform.name }}
{% endif -%}
{% endfor -%}
{% endfor -%}
{% endfor -%}
Expand Down
12 changes: 12 additions & 0 deletions .yamato/_triggers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,16 @@ develop_nightly:
- .yamato/code-coverage.yml#code_coverage_win_{{ project.name }}
{% endfor -%}

develop_weekly_trunk:
name: "[Weekly] Run All Tests [Trunk]"
triggers:
recurring:
- branch: develop
frequency: weekly
rerun: always
dependencies:
- .yamato/_run-all.yml#run_all_tests_trunk

multiprocess_nightly:
name: "[Nightly] Run Multiprocess Tests"
triggers:
Expand Down Expand Up @@ -77,9 +87,11 @@ badges_test_trigger:
- .yamato/project-tests.yml#validate_{{ package.name }}_{{ test_platforms.first.name }}_{{ validation_editor }}
{% endif -%}
{% for editor in project.test_editors -%}
{% if editor != "trunk" -%}
{% for platform in test_platforms -%}
- .yamato/package-tests.yml#test_{{ project.name }}_{{ package.name }}_{{ editor }}_{{ platform.name }}
{% endfor -%}
{% endif -%}
{% endfor -%}
{% endfor -%}
{% endfor -%}
6 changes: 3 additions & 3 deletions .yamato/code-coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
{% metadata_file .yamato/project.metafile %}
---
{% for project in projects -%}
code_coverage_win_{{ project.name }}:
name: Code Coverage Report - Windows - {{ project.name }}
code_coverage_win_{{ project.name }}_{{ validation_editor }}:
name: Code Coverage Report - Windows - {{ project.name }} - {{ validation_editor }}
agent:
type: Unity::VM
image: package-ci/win10:stable
flavor: b1.large
commands:
- pip install unity-downloader-cli --upgrade --index-url https://artifactory.prd.it.unity3d.com/artifactory/api/pypi/pypi/simple
- npm install upm-ci-utils@stable -g --registry https://artifactory.prd.cds.internal.unity3d.com/artifactory/api/npm/upm-npm
- unity-downloader-cli -u trunk -c editor --wait --fast
- unity-downloader-cli -u {{ validation_editor }} -c editor --wait --fast
Copy link
Copy Markdown
Contributor

@0xFA11 0xFA11 May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did you set validation_editor variable?
if only yamato ui, I'd suggest adding this variable to project.metafile as a fallback when yamato variable is not set.

- upm-ci package test -u .Editor --package-path com.unity.netcode.gameobjects --enable-code-coverage --code-coverage-options 'enableCyclomaticComplexity;generateAdditionalMetrics;generateHtmlReport;assemblyFilters:+Unity.Netcode.Editor,+Unity.Netcode.Runtime,+Unity.Netcode.Components'
artifacts:
logs:
Expand Down