[NetworkAnimator bug] Cannot re-host a game after pressing 'return to menu' from the BossRoom scene - NetworkAnimator null reference exception (does not happen after going to main menu from CharSelect or PostGame)

[11BelowStudio]

Describe the bug
Using the 'return to menu' button in the BossRoom scene causes a NullReferenceException to be thrown by NetworkAnimator.OnClientConnectedCallback upon attempting to host a new game. NetworkManager.StartHost() itself works, but as this exception prevents the game from going to CharSelect, the player, with no way of stopping the NetworkManager, is stuck and is forced to quit the game.

To Reproduce

1. Enter play mode
2. Host via IP, click on 'host'
3. Pick a character on CharSelect, wait for the main Boss Room scene to load
4. Use the 'go to main menu' button within the Boss Room scene
5. Attempt to host a new game via IP, click the 'host' button again.
6. Error (NullReferenceException within Unity.Netcode.Components.NetworkAnimator.OnClientConnectedCallback).
   • The NetworkManager.StartHost() call succeeds, but the exception prevents CharSelect from being loaded.
   • PopupManager does not show a 'hosting failed' error dialog in the game itself when this happens. Clicking the 'host' button again will cause the 'hosting failed' error dialog to appear (Cannot start Host while an instance is already running message appears in console).

Expected behavior
The game should proceed to the 'CharSelect' scene, allowing the user to continue hosting the game as expected.

Screenshots

The above screenshot shows what happens after clicking on 'Host' after first clicking 'return to menu' as a host in the BossRoom scene. As you can see, the NetworkManager has been able to start hosting, but due to a null reference exception in NetworkAnimator, the game itself hasn't been able to proceed to the Charselect scene from the MainMenu.

Environment (please complete the following information):

• OS: Windows 8.1
• Unity Version: 2021.3.3f1
• BossRoom Version: v1.3.0-pre

Additional context

• This problem only happens if you press 'return to menu' from the BossRoom scene. The 'return to main menu' buttons in CharSelect and PostGame do not have this problem.
• Haven't tested if the problem affects relay connections, but chances are it will affect those as well.
• Haven't tested if it affects clients yet (whether voluntarily disconnecting or involuntarily disconnecting).

Stack trace

NullReferenceException: Object reference not set to an instance of an object
Unity.Netcode.Components.NetworkAnimator.OnClientConnectedCallback (System.UInt64 playerId) (at Library/PackageCache/com.unity.netcode.gameobjects@1.0.0-pre.10/Components/NetworkAnimator.cs:446)
Unity.Netcode.NetworkManager.InvokeOnClientConnectedCallback (System.UInt64 clientId) (at Library/PackageCache/com.unity.netcode.gameobjects@1.0.0-pre.10/Runtime/Core/NetworkManager.cs:352)
Unity.Netcode.NetworkManager.HandleConnectionApproval (System.UInt64 ownerClientId, Unity.Netcode.NetworkManager+ConnectionApprovalResponse response) (at Library/PackageCache/com.unity.netcode.gameobjects@1.0.0-pre.10/Runtime/Core/NetworkManager.cs:2028)
Unity.Netcode.NetworkManager.StartHost () (at Library/PackageCache/com.unity.netcode.gameobjects@1.0.0-pre.10/Runtime/Core/NetworkManager.cs:1080)
Unity.Multiplayer.Samples.BossRoom.GameNetPortal.StartHost () (at Assets/Scripts/Gameplay/ConnectionManagement/GameNetPortal.cs:217)
Unity.Multiplayer.Samples.BossRoom.GameNetPortal.StartHost (System.String ipaddress, System.Int32 port) (at Assets/Scripts/Gameplay/ConnectionManagement/GameNetPortal.cs:185)
Unity.Multiplayer.Samples.BossRoom.Visual.IPUIMediator.HostIPRequest (System.String ip, System.String port) (at Assets/Scripts/Gameplay/UI/IPUIMediator.cs:83)
Unity.Multiplayer.Samples.BossRoom.Visual.IPHostingUI.OnCreateClick () (at Assets/Scripts/Gameplay/UI/IPHostingUI.cs:43)
UnityEngine.Events.InvokableCall.Invoke () (at <f1212ad1dec44ce7b7147976b91869c3>:0)
UnityEngine.Events.UnityEvent.Invoke () (at <f1212ad1dec44ce7b7147976b91869c3>:0)
UnityEngine.UI.Button.Press () (at Library/PackageCache/com.unity.ugui@1.0.0/Runtime/UI/Core/Button.cs:70)
UnityEngine.UI.Button.OnPointerClick (UnityEngine.EventSystems.PointerEventData eventData) (at Library/PackageCache/com.unity.ugui@1.0.0/Runtime/UI/Core/Button.cs:114)
UnityEngine.EventSystems.ExecuteEvents.Execute (UnityEngine.EventSystems.IPointerClickHandler handler, UnityEngine.EventSystems.BaseEventData eventData) (at Library/PackageCache/com.unity.ugui@1.0.0/Runtime/EventSystem/ExecuteEvents.cs:57)
UnityEngine.EventSystems.ExecuteEvents.Execute[T] (UnityEngine.GameObject target, UnityEngine.EventSystems.BaseEventData eventData, UnityEngine.EventSystems.ExecuteEvents+EventFunction`1[T1] functor) (at Library/PackageCache/com.unity.ugui@1.0.0/Runtime/EventSystem/ExecuteEvents.cs:272)
UnityEngine.EventSystems.EventSystem:Update() (at Library/PackageCache/com.unity.ugui@1.0.0/Runtime/EventSystem/EventSystem.cs:501)

[LPLafontaineB]

Hi @11BelowStudio ,
Thank you for submitting this issue! After some investigation, it seems to be an issue with the NetworkAnimator itself. It looks like it does not properly unregister the OnClientConnected callback when the server shuts down. I'll transfer this issue to the Netcode for GameObjects project.

[LPLafontaineB]

To give a bit more details about the issue causing this:
NetworkAnimator registers to NetworkManager's OnClientConnectedCallback when spawning, if IsServer is true. It then de-registers it when despawning. However in the case of a shut down, IsServer is set to false before the despawn happens, so it is not de-registered.

[TheCaveOfWonders]

having the same issue in my project.

System.NullReferenceException: Object reference not set to an instance of an object
at Unity.Netcode.Components.NetworkAnimator.OnClientConnectedCallback (System.UInt64 playerId) [0x00001] in E:\New folder\mygame\Library\PackageCache\com.unity.netcode.gameobjects@1.0.0-pre.10\Components\NetworkAnimator.cs:446
at (wrapper delegate-invoke) System.Action1[System.UInt64].invoke_void_T(ulong)
at Unity.Netcode.NetworkManager.InvokeOnClientConnectedCallback (System.UInt64 clientId) [0x00000] in E:\New folder\mygame\Library\PackageCache\com.unity.netcode.gameobjects@1.0.0-pre.10\Runtime\Core\NetworkManager.cs:352
at Unity.Netcode.NetworkManager.HandleConnectionApproval (System.UInt64 ownerClientId, Unity.Netcode.NetworkManager+ConnectionApprovalResponse response) [0x001c0] in E:\New folder\mygame\Library\PackageCache\com.unity.netcode.gameobjects@1.0.0-pre.10\Runtime\Core\NetworkManager.cs:2028
at Unity.Netcode.NetworkManager.StartHost () [0x00174] in E:\New folder\mygame\Library\PackageCache\com.unity.netcode.gameobjects@1.0.0-pre.10\Runtime\Core\NetworkManager.cs:1080
at Game.Network.GameNetPortal.StartHost (System.String ipaddress, System.Int32 port) [0x00088] in E:\New folder\mygame\Assets\Scripts\Game\Network\GameNetPortal.cs:278
0x00007ff694730c3d (Unity) StackWalker::GetCurrentCallstack
0x00007ff694737919 (Unity) StackWalker::ShowCallstack
0x00007ff6956a48b3 (Unity) GetStacktrace
0x00007ff695d398ad (Unity) DebugStringToFile
0x00007ff69389c3a2 (Unity) DebugLogHandler_CUSTOM_Internal_Log
0x00000237d5b558ea (Mono JIT Code) (wrapper managed-to-native) UnityEngine.DebugLogHandler:Internal_Log (UnityEngine.LogType,UnityEngine.LogOption,string,UnityEngine.Object)
0x00000237d5b5575b (Mono JIT Code) UnityEngine.DebugLogHandler:LogFormat (UnityEngine.LogType,UnityEngine.Object,string,object[])
0x00000237d5b54bde (Mono JIT Code) UnityEngine.Logger:Log (UnityEngine.LogType,object)
0x000002384cba06ba (Mono JIT Code) UnityEngine.Debug:LogError (object)
0x00000236c2d07993 (Mono JIT Code) [GameNetPortal.cs:282] Game.Network.GameNetPortal:StartHost (string,int)
0x00000236c2d00ae3 (Mono JIT Code) [HostGamePage.cs:66] Assets.Scripts.Game.UI.HostGamePage/d__8:MoveNext ()
0x00000236c0e34ef2 (Mono JIT Code) System.Runtime.CompilerServices.AsyncVoidMethodBuilder:Start<TStateMachine_REF> (TStateMachine_REF&)
0x00000236c2cefb73 (Mono JIT Code) Assets.Scripts.Game.UI.HostGamePage:HostGame ()
0x00000236bff68cc7 (Mono JIT Code) UnityEngine.Events.InvokableCall:Invoke ()
0x00000236bff679cb (Mono JIT Code) UnityEngine.Events.UnityEvent:Invoke ()
0x00000236c2cc7093 (Mono JIT Code) [Button.cs:70] UnityEngine.UI.Button:Press ()
0x00000236c2cc6e6b (Mono JIT Code) [Button.cs:114] UnityEngine.UI.Button:OnPointerClick (UnityEngine.EventSystems.PointerEventData)
0x00000236c2cc6d0d (Mono JIT Code) [ExecuteEvents.cs:57] UnityEngine.EventSystems.ExecuteEvents:Execute (UnityEngine.EventSystems.IPointerClickHandler,UnityEngine.EventSystems.BaseEventData)
0x00000236c2cb3704 (Mono JIT Code) [ExecuteEvents.cs:272] UnityEngine.EventSystems.ExecuteEvents:Execute<T_REF> (UnityEngine.GameObject,UnityEngine.EventSystems.BaseEventData,UnityEngine.EventSystems.ExecuteEvents/EventFunction1<T_REF>)
0x00000236c2cc2b33 (Mono JIT Code) [InputSystemUIInputModule.cs:507] UnityEngine.InputSystem.UI.InputSystemUIInputModule:ProcessPointerButton (UnityEngine.InputSystem.UI.PointerModel/ButtonState&,UnityEngine.EventSystems.PointerEventData)
0x00000236c2c9f623 (Mono JIT Code) [InputSystemUIInputModule.cs:308] UnityEngine.InputSystem.UI.InputSystemUIInputModule:ProcessPointer (UnityEngine.InputSystem.UI.PointerModel&)
0x00000236c2c2acab (Mono JIT Code) [InputSystemUIInputModule.cs:2024] UnityEngine.InputSystem.UI.InputSystemUIInputModule:Process ()
0x00000236c10523ac (Mono JIT Code) [EventSystem.cs:501] UnityEngine.EventSystems.EventSystem:Update ()
0x000002383add1198 (Mono JIT Code) (wrapper runtime-invoke) object:runtime_invoke_void__this__ (object,intptr,intptr,intptr)
0x00007ffcd1e6e334 (mono-2.0-bdwgc) [mini-runtime.c:3445] mono_jit_runtime_invoke
0x00007ffcd1dae764 (mono-2.0-bdwgc) [object.c:3066] do_runtime_invoke
0x00007ffcd1dae8fc (mono-2.0-bdwgc) [object.c:3113] mono_runtime_invoke
0x00007ff6946555b4 (Unity) scripting_method_invoke
0x00007ff6946501d4 (Unity) ScriptingInvocation::Invoke
0x00007ff69461de44 (Unity) MonoBehaviour::CallMethodIfAvailable
0x00007ff69461df4c (Unity) MonoBehaviour::CallUpdateMethod
0x00007ff694115918 (Unity) BaseBehaviourManager::CommonUpdate
0x00007ff69411cefa (Unity) BehaviourManager::Update
0x00007ff69432d75d (Unity) InitPlayerLoopCallbacks::2::UpdateScriptRunBehaviourUpdateRegistrator::Forward
0x00007ff69431437c (Unity) ExecutePlayerLoop
0x00007ff694314453 (Unity) ExecutePlayerLoop
0x00007ff69431a099 (Unity) PlayerLoop
0x00007ff695260ce4 (Unity) PlayerLoopController::UpdateScene
0x00007ff69525ef5f (Unity) Application::TickTimer
0x00007ff6956aaa4a (Unity) MainMessageLoop
0x00007ff6956af2fb (Unity) WinMain
0x00007ff6969e18ee (Unity) __scrt_common_main_seh
0x00007ffd86357034 (KERNEL32) BaseThreadInitThunk
0x00007ffd87782651 (ntdll) RtlUserThreadStart

[NoelStephensUnity]

@TheCaveOfWonders
I am truly sorry you are experiencing this bug as it is a regression bug from some of my recent updates/fixes applied to NetworkAnimator. Currently we don't have an ETA for when the next update will be made available since we just published the v1.0.0 release version today. So, for the time being there are two paths you can take to work around this issue:

Download the V1.0.0 source code

You can always download the v1.0.0 source code source code and remove the IsServer check within the NetworkAnimator.Cleanup method so the callback is always removed.
The modified method would then look like this:

private void Cleanup()
{
    if (m_NetworkAnimatorStateChangeHandler != null)
    {
        m_NetworkAnimatorStateChangeHandler.DeregisterUpdate();
        m_NetworkAnimatorStateChangeHandler = null;
    }
    
    //Note: This is where the IsServer check is removed
    NetworkManager.OnClientConnectedCallback -= OnClientConnectedCallback;

    if (m_CachedAnimatorParameters != null && m_CachedAnimatorParameters.IsCreated)
    {
        m_CachedAnimatorParameters.Dispose();
    }
    if (m_ParameterWriter.IsInitialized)
    {
        m_ParameterWriter.Dispose();
    }
}

The only other adjustment you would need to make, to apply those changes to your project, is to open the package manager, select a package from disk, and select the \com.unity.netcode.gameobjects-1.0.0\com.unity.netcode.gameobjects\package.json file. In the next update, this will most definitely be fixed and then you can update to that new package.

Continue Using the Package

Currently, I have found several temporary work arounds when using the Netcode for GameObjects package. However, the only one that didn't exceed the complexity of the previous option was to destroy the NetworkManager instance once it is completely shutdown (sub-optimal). Then you would need to create a new instance if you wanted to start another session.
Note: You will want to save the NetworkManager.NetworkConfig of the NetworkManager instance you are destroying and apply that to the next instance you create.

Let me know if you have any further questions or issues with this particular bug and if either temporary work around helped you resolve your issue (until the fix is published).