NetworkTransform behaviour when InLocalSpace changes

[daalen]

Is your feature request related to a problem? Please describe.
If NetworkTransform's InLocalSpace changes during runtime, and interpolation is on, the object is teleported to its previous local coordinates in world coordinates or vice versa, before smoothly moving back to its correct position.

Describe the solution you'd like
NetworkTransform should notice when InLocalSpace changed, and Teleport to the position in the correct coordinate system.

Describe alternatives you've considered
I currently overwrite the position right after a change of space.

EDIT: From reading the code, I see that something is already in place for this – and yet I have issues. Perhaps it is because the checks for interpolation and localspace changes in NetworkTransform sometimes only go one way: from interpolated to not interpolated but not the other way around, for instance.

[NoelStephensUnity]

Hello @daalen!
We will continue to look for ways to improve Netcode for GameObjects.
While we consider the suggested feature, could you further describe what feature you were trying to implement in your project when you ran into this issue?

[daalen]

Sure – I was trying to work around the fact that direct parenting of networkobjects to children of networkobjects (e.g. to the hand or back of a player object) is not possible. In the solution that I ended up with I parent to the root of the player object, switch to local space and non-interpolated, and update the position based on the movement of the body part of the player.

[NoelStephensUnity]

@daalen
Just checking in. I think some of the issue you might have been encountering could be helped by a pending PR.
However, after re-reading your solution and what you were doing I was wondering if, once parented, you just disabled the NetworkTransform?
If you are parenting under a GameObject with a NetworkTransform component, then the child should move automatically with the parent's motion and rotation. You would just need to make sure any offset in local space position or rotation is applied on the server side when NetworkBehaviour.OnNetworkObjectParentChanged is invoked (on the child) and then after that disable the child's NetworkTransform. Position and Rotation are synchronized when the parented message is sent (basically the message is sent right after NetworkBehaviour.OnNetworkObjectParentChanged is invoked on the server side. This is invoked on all clients as well so they, in turn, could disable the NetworkTransform when that event occurs.
When the parent is removed, you would basically re-enabled the NetworkTransform.

[daalen]

Ah, I wasn't aware that disabling a NetworkTransform was a valid thing to do, I think I was assuming that breaks something. I'll give that a shot, thank you.

[NoelStephensUnity]

If that doesn't work out, you can try disabling the Sync properties and then re-enabling them when you are done.

[NoelStephensUnity]

This issue is resolved in #2388