Skip to content

fix: making key press 1 revive and pickup/drop pots [MTT-4802]#770

Merged
fernando-cortez merged 3 commits intodevelopfrom
fix/key-press-action
Oct 20, 2022
Merged

fix: making key press 1 revive and pickup/drop pots [MTT-4802]#770
fernando-cortez merged 3 commits intodevelopfrom
fix/key-press-action

Conversation

@fernando-cortez
Copy link
Copy Markdown
Contributor

@fernando-cortez fernando-cortez commented Oct 20, 2022

Description

This PR addresses the issue where pressing 1 would not revive or pickup/drop pots. Instead of requests for actions being funneled through UI scripts, they simply read the current action for 1/2/3 keys from ClientInputSender, the class that now holds authority on modifying a character's Action.

Issue Number(s)

MTT-4802

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@fernando-cortez fernando-cortez added the 1-Needs Review PR needs attention from the assignee and reviewers label Oct 20, 2022
@LPLafontaineB LPLafontaineB added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Oct 20, 2022
@fernando-cortez fernando-cortez merged commit e63f6e2 into develop Oct 20, 2022
@fernando-cortez fernando-cortez deleted the fix/key-press-action branch October 20, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2-One More Review One review in, one to go

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants